[incubator-uniffle] branch master updated: [FOLLOWUP] Remove unused methods in Storage interface (#431)

[zuston]

This is an automated email from the ASF dual-hosted git repository.

zuston pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-uniffle.git


The following commit(s) were added to refs/heads/master by this push:
     new d8970594 [FOLLOWUP] Remove unused methods in Storage interface (#431)
d8970594 is described below

commit d8970594ca4c2f81e98b33d93e4bc8b05f695deb
Author: Junfan Zhang <zus...@apache.org>
AuthorDate: Fri Dec 16 15:01:10 2022 +0800

    [FOLLOWUP] Remove unused methods in Storage interface (#431)
    
    
    ### What changes were proposed in this pull request?
    1. Remove unused methods in Storage interface
    
    ### Why are the changes needed?
    
    1. Remove it to make more clear.
    
    ### Does this PR introduce _any_ user-facing change?
    No
    
    ### How was this patch tested?
    Don't need
---
 .../uniffle/storage/common/AbstractStorage.java       | 12 ------------
 .../apache/uniffle/storage/common/HdfsStorage.java    | 10 ----------
 .../apache/uniffle/storage/common/LocalStorage.java   | 19 -------------------
 .../org/apache/uniffle/storage/common/Storage.java    |  6 ------
 4 files changed, 47 deletions(-)

diff --git 
a/storage/src/main/java/org/apache/uniffle/storage/common/AbstractStorage.java 
b/storage/src/main/java/org/apache/uniffle/storage/common/AbstractStorage.java
index 80125a63..d2c7884d 100644
--- 
a/storage/src/main/java/org/apache/uniffle/storage/common/AbstractStorage.java
+++ 
b/storage/src/main/java/org/apache/uniffle/storage/common/AbstractStorage.java
@@ -81,18 +81,6 @@ public abstract class AbstractStorage implements Storage {
     return map.containsKey(partitionKey);
   }
 
-  @Override
-  public CreateShuffleWriteHandlerRequest getCreateWriterHandlerRequest(
-      String appId,
-      int shuffleId,
-      int partition) {
-    Map<String, CreateShuffleWriteHandlerRequest> requestMap = 
requests.get(appId);
-    if (requestMap != null) {
-      return requestMap.get(RssUtils.generatePartitionKey(appId, shuffleId, 
partition));
-    }
-    return null;
-  }
-
   @Override
   public void removeHandlers(String appId) {
     writerHandlers.remove(appId);
diff --git 
a/storage/src/main/java/org/apache/uniffle/storage/common/HdfsStorage.java 
b/storage/src/main/java/org/apache/uniffle/storage/common/HdfsStorage.java
index 46ae771f..42c93c03 100644
--- a/storage/src/main/java/org/apache/uniffle/storage/common/HdfsStorage.java
+++ b/storage/src/main/java/org/apache/uniffle/storage/common/HdfsStorage.java
@@ -76,16 +76,6 @@ public class HdfsStorage extends AbstractStorage {
     return true;
   }
 
-  @Override
-  public boolean lockShuffleExcluded(String shuffleKey) {
-    return true;
-  }
-
-  @Override
-  public boolean unlockShuffleExcluded(String shuffleKey) {
-    return true;
-  }
-
   @Override
   public void updateReadMetrics(StorageReadMetrics metrics) {
     // do nothing
diff --git 
a/storage/src/main/java/org/apache/uniffle/storage/common/LocalStorage.java 
b/storage/src/main/java/org/apache/uniffle/storage/common/LocalStorage.java
index e5dd840a..2941a3ec 100644
--- a/storage/src/main/java/org/apache/uniffle/storage/common/LocalStorage.java
+++ b/storage/src/main/java/org/apache/uniffle/storage/common/LocalStorage.java
@@ -121,25 +121,6 @@ public class LocalStorage extends AbstractStorage {
     return true;
   }
 
-  @Override
-  public boolean lockShuffleExcluded(String shuffleKey) {
-    ReadWriteLock lock = getLock(shuffleKey);
-    if (lock == null) {
-      return false;
-    }
-    return lock.writeLock().tryLock();
-  }
-
-  @Override
-  public boolean unlockShuffleExcluded(String shuffleKey) {
-    ReadWriteLock lock = getLock(shuffleKey);
-    if (lock == null) {
-      return false;
-    }
-    lock.writeLock().unlock();
-    return true;
-  }
-
   @Override
   public void updateWriteMetrics(StorageWriteMetrics metrics) {
     updateWrite(RssUtils.generateShuffleKey(metrics.getAppId(), 
metrics.getShuffleId()),
diff --git 
a/storage/src/main/java/org/apache/uniffle/storage/common/Storage.java 
b/storage/src/main/java/org/apache/uniffle/storage/common/Storage.java
index ab2878fa..f2fb9c61 100644
--- a/storage/src/main/java/org/apache/uniffle/storage/common/Storage.java
+++ b/storage/src/main/java/org/apache/uniffle/storage/common/Storage.java
@@ -33,10 +33,6 @@ public interface Storage {
 
   boolean unlockShuffleShared(String shuffleKey);
 
-  boolean lockShuffleExcluded(String shuffleKey);
-
-  boolean unlockShuffleExcluded(String shuffleKey);
-
   void updateWriteMetrics(StorageWriteMetrics metrics);
 
   void updateReadMetrics(StorageReadMetrics metrics);
@@ -45,8 +41,6 @@ public interface Storage {
 
   ServerReadHandler getOrCreateReadHandler(CreateShuffleReadHandlerRequest 
request);
 
-  CreateShuffleWriteHandlerRequest getCreateWriterHandlerRequest(String appId, 
int shuffleId, int partition);
-
   void removeHandlers(String appId);
 
   void createMetadataIfNotExist(String shuffleKey);