[incubator-uniffle] branch master updated: [Improvement] Add more logs about data flush (#482)

[zuston]

This is an automated email from the ASF dual-hosted git repository.

zuston pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-uniffle.git


The following commit(s) were added to refs/heads/master by this push:
     new 63c1d71a [Improvement] Add more logs about data flush (#482)
63c1d71a is described below

commit 63c1d71a77b5c6e111390a8c44a4f90536f96a75
Author: Junfan Zhang <zus...@apache.org>
AuthorDate: Fri Jan 13 12:16:09 2023 +0800

    [Improvement] Add more logs about data flush (#482)
    
    ### What changes were proposed in this pull request?
    
    1. Exposing more info for DataFlushEvent when logging
    2. Add logs when storage selected is null
    
    ### Why are the changes needed?
    
    1. I found sometimes some events are flushed failed but have no related 
logs, maybe this is caused by the null storage selected. So let's add some logs 
firstly.
    
    ### Does this PR introduce _any_ user-facing change?
    
    No
    
    
    ### How was this patch tested?
    
    Don't need
---
 .../main/java/org/apache/uniffle/server/ShuffleDataFlushEvent.java   | 5 ++++-
 .../src/main/java/org/apache/uniffle/server/ShuffleFlushManager.java | 1 +
 2 files changed, 5 insertions(+), 1 deletion(-)

diff --git 
a/server/src/main/java/org/apache/uniffle/server/ShuffleDataFlushEvent.java 
b/server/src/main/java/org/apache/uniffle/server/ShuffleDataFlushEvent.java
index 883ef14a..6829ab0a 100644
--- a/server/src/main/java/org/apache/uniffle/server/ShuffleDataFlushEvent.java
+++ b/server/src/main/java/org/apache/uniffle/server/ShuffleDataFlushEvent.java
@@ -158,6 +158,9 @@ public class ShuffleDataFlushEvent {
         + ", appId=" + appId
         + ", shuffleId=" + shuffleId
         + ", startPartition=" + startPartition
-        + ", endPartition=" + endPartition;
+        + ", endPartition=" + endPartition
+        + ", retryTimes=" + retryTimes
+        + ", underStorage=" + underStorage.getClass().getSimpleName()
+        + ", isPended=" + isPended;
   }
 }
diff --git 
a/server/src/main/java/org/apache/uniffle/server/ShuffleFlushManager.java 
b/server/src/main/java/org/apache/uniffle/server/ShuffleFlushManager.java
index 62f1c3ae..dc862195 100644
--- a/server/src/main/java/org/apache/uniffle/server/ShuffleFlushManager.java
+++ b/server/src/main/java/org/apache/uniffle/server/ShuffleFlushManager.java
@@ -165,6 +165,7 @@ public class ShuffleFlushManager {
 
         Storage storage = storageManager.selectStorage(event);
         if (storage == null) {
+          LOG.error("Storage selected is null and this should not happen. 
event: {}", event);
           break;
         }