This is an automated email from the ASF dual-hosted git repository.
roryqi pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-uniffle.git
The following commit(s) were added to refs/heads/master by this push:
new b98f9fd9 [#647][FOLLOWUP] set coordinator id before ApplicationMaster
(#654)
b98f9fd9 is described below
commit b98f9fd9f2399530dd25f54aa1d3bb8eeb136943
Author: advancedxy <[email protected]>
AuthorDate: Fri Feb 24 14:50:44 2023 +0800
[#647][FOLLOWUP] set coordinator id before ApplicationMaster (#654)
### What changes were proposed in this pull request?
set coordinator id before ApplicationMaster construction, otherwise uuid is
used for ` AbstractSelectStorageStrategy`
### Why are the changes needed?
Follow up of #647
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Manually verified
---
.../src/main/java/org/apache/uniffle/coordinator/CoordinatorServer.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
a/coordinator/src/main/java/org/apache/uniffle/coordinator/CoordinatorServer.java
b/coordinator/src/main/java/org/apache/uniffle/coordinator/CoordinatorServer.java
index a946062a..a016df6a 100644
---
a/coordinator/src/main/java/org/apache/uniffle/coordinator/CoordinatorServer.java
+++
b/coordinator/src/main/java/org/apache/uniffle/coordinator/CoordinatorServer.java
@@ -149,6 +149,7 @@ public class CoordinatorServer extends ReconfigurableBase {
jettyServer = new JettyServer(coordinatorConf);
// register metrics first to avoid NPE problem when add dynamic metrics
registerMetrics();
+ coordinatorConf.setString(CoordinatorUtils.COORDINATOR_ID, id);
this.applicationManager = new ApplicationManager(coordinatorConf);
SecurityConfig securityConfig = null;
@@ -162,7 +163,6 @@ public class CoordinatorServer extends ReconfigurableBase {
}
SecurityContextFactory.get().init(securityConfig);
- coordinatorConf.setString(CoordinatorUtils.COORDINATOR_ID, id);
// load default hadoop configuration
Configuration hadoopConf = new Configuration();