[incubator-uniffle] branch master updated: [#691] fix(test): flaky test CoordinatorMetricsTest#testCoordinatorMetrics

[roryqi]

This is an automated email from the ASF dual-hosted git repository.

roryqi pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-uniffle.git


The following commit(s) were added to refs/heads/master by this push:
     new 272c5c6a [#691] fix(test):  flaky test 
CoordinatorMetricsTest#testCoordinatorMetrics
272c5c6a is described below

commit 272c5c6a626e63ead468d55dae87663d0b1ab2c3
Author: jokercurry <84573424+smallzhongf...@users.noreply.github.com>
AuthorDate: Thu Mar 9 11:56:01 2023 +0800

    [#691] fix(test):  flaky test CoordinatorMetricsTest#testCoordinatorMetrics
    
    ### What changes were proposed in this pull request?
    Do not start quotaManager when performing ut test of indicators.
    
    ### Why are the changes needed?
    Fix: #691
    
    ### Does this PR introduce _any_ user-facing change?
    No.
    
    ### How was this patch tested?
    Fix ut.
---
 .../uniffle/coordinator/metric/CoordinatorMetricsTest.java       | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git 
a/coordinator/src/test/java/org/apache/uniffle/coordinator/metric/CoordinatorMetricsTest.java
 
b/coordinator/src/test/java/org/apache/uniffle/coordinator/metric/CoordinatorMetricsTest.java
index 0fcb3d04..945cafda 100644
--- 
a/coordinator/src/test/java/org/apache/uniffle/coordinator/metric/CoordinatorMetricsTest.java
+++ 
b/coordinator/src/test/java/org/apache/uniffle/coordinator/metric/CoordinatorMetricsTest.java
@@ -89,7 +89,14 @@ public class CoordinatorMetricsTest {
     ObjectMapper mapper = new ObjectMapper();
     JsonNode actualObj = mapper.readTree(content);
     assertEquals(2, actualObj.size());
-    assertEquals(10, actualObj.get("metrics").size());
+    int actualMetrics = 0;
+    for (JsonNode metrics : actualObj.get("metrics")) {
+      if 
(CoordinatorMetrics.APP_NUM_TO_USER.equals(metrics.get("name").textValue())) {
+        continue;
+      }
+      actualMetrics++;
+    }
+    assertEquals(10, actualMetrics);
   }
 
   @Test