This is an automated email from the ASF dual-hosted git repository.

ckj pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-uniffle.git


The following commit(s) were added to refs/heads/master by this push:
     new 1021031b [MINOR] test: fix 
CoordinatorGrpcTest#shuffleServerHeartbeatTest on Linux SSD platform (#738)
1021031b is described below

commit 1021031b5eb1f4b97448f6431ea23e13a691b874
Author: Kaijie Chen <[email protected]>
AuthorDate: Sat Mar 18 22:30:30 2023 +0800

    [MINOR] test: fix CoordinatorGrpcTest#shuffleServerHeartbeatTest on Linux 
SSD platform (#738)
    
    ### What changes were proposed in this pull request?
    
    Fix CoordinatorGrpcTest#shuffleServerHeartbeatTest on Linux SSD platform
    
    ### Why are the changes needed?
    
    ```
    [INFO] Results:
    [INFO]
    [ERROR] Failures:
    [ERROR]   CoordinatorGrpcTest.shuffleServerHeartbeatTest:240 expected: 
<HDD> but was: <SSD>
    [ERROR] Errors:
    [ERROR]   CoordinatorGrpcTest.getShuffleAssignmentsTest:125 » Runtime No 
shuffle server ...
    [ERROR]   CoordinatorGrpcTest.rpcMetricsTest:274 » Runtime No shuffle 
server connected
    [INFO]
    [ERROR] Tests run: 6, Failures: 1, Errors: 2, Skipped: 0
    ```
    
    ### Does this PR introduce _any_ user-facing change?
    
    No.
    
    ### How was this patch tested?
    
    ```
    [INFO] Running org.apache.uniffle.test.CoordinatorGrpcTest
    [INFO] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
21.622 s - in org.apache.uniffle.test.CoordinatorGrpcTest
    [INFO]
    [INFO] Results:
    [INFO]
    [INFO] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0
    [INFO]
    ```
---
 .../src/test/java/org/apache/uniffle/test/CoordinatorGrpcTest.java    | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git 
a/integration-test/common/src/test/java/org/apache/uniffle/test/CoordinatorGrpcTest.java
 
b/integration-test/common/src/test/java/org/apache/uniffle/test/CoordinatorGrpcTest.java
index e3091a43..9b63df7c 100644
--- 
a/integration-test/common/src/test/java/org/apache/uniffle/test/CoordinatorGrpcTest.java
+++ 
b/integration-test/common/src/test/java/org/apache/uniffle/test/CoordinatorGrpcTest.java
@@ -237,7 +237,9 @@ public class CoordinatorGrpcTest extends 
CoordinatorTestBase {
     ServerNode node = nodes.get(0);
     assertEquals(1, node.getStorageInfo().size());
     StorageInfo infoHead = node.getStorageInfo().values().iterator().next();
-    assertEquals(StorageMedia.HDD, infoHead.getType());
+    final StorageInfo expectedStorageInfo = shuffleServers.get(1)
+        .getStorageManager().getStorageInfo().values().iterator().next();
+    assertEquals(expectedStorageInfo, infoHead);
     assertEquals(StorageStatus.NORMAL, infoHead.getStatus());
     assertTrue(node.getTags().contains(Constants.SHUFFLE_SERVER_VERSION));
     
assertTrue(scm.getTagToNodes().get(Constants.SHUFFLE_SERVER_VERSION).contains(node));

Reply via email to