This is an automated email from the ASF dual-hosted git repository.
rickyma pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-uniffle.git
The following commit(s) were added to refs/heads/master by this push:
new e18f81c13 [#1401] improvement(dashboard): Remove the ugly underline on
the shuffle server page. (#1871)
e18f81c13 is described below
commit e18f81c1374cd75b1c750a7878e1c1537c762603
Author: yl09099 <33595968+yl09...@users.noreply.github.com>
AuthorDate: Mon Jul 8 10:48:08 2024 +0800
[#1401] improvement(dashboard): Remove the ugly underline on the shuffle
server page. (#1871)
### What changes were proposed in this pull request?
Remove the ugly underline on the shuffle server page.
### Why are the changes needed?
Fix: #1401
### Does this PR introduce _any_ user-facing change?
Yes.
### How was this patch tested?
No testing required.
---
.../src/main/webapp/src/pages/ApplicationPage.vue | 14 +++++++++++--
.../main/webapp/src/pages/ShuffleServerPage.vue | 23 +++++++++++-----------
2 files changed, 23 insertions(+), 14 deletions(-)
diff --git a/dashboard/src/main/webapp/src/pages/ApplicationPage.vue
b/dashboard/src/main/webapp/src/pages/ApplicationPage.vue
index e3ef4cab9..fdaa009ab 100644
--- a/dashboard/src/main/webapp/src/pages/ApplicationPage.vue
+++ b/dashboard/src/main/webapp/src/pages/ApplicationPage.vue
@@ -43,8 +43,18 @@
<el-table :data="pageData.appInfoData" height="250" style="width: 100%">
<el-table-column prop="appId" label="AppId" min-width="180" />
<el-table-column prop="userName" label="UserName" min-width="180" />
- <el-table-column prop="registrationTime" label="Registration Time"
min-width="180" :formatter="dateFormatter" />
- <el-table-column prop="updateTime" label="Update Time" min-width="180"
:formatter="dateFormatter" />
+ <el-table-column
+ prop="registrationTime"
+ label="Registration Time"
+ min-width="180"
+ :formatter="dateFormatter"
+ />
+ <el-table-column
+ prop="updateTime"
+ label="Update Time"
+ min-width="180"
+ :formatter="dateFormatter"
+ />
</el-table>
</div>
</div>
diff --git a/dashboard/src/main/webapp/src/pages/ShuffleServerPage.vue
b/dashboard/src/main/webapp/src/pages/ShuffleServerPage.vue
index 6c70f42dd..a58b7995f 100644
--- a/dashboard/src/main/webapp/src/pages/ShuffleServerPage.vue
+++ b/dashboard/src/main/webapp/src/pages/ShuffleServerPage.vue
@@ -19,7 +19,7 @@
<div>
<el-row :gutter="20">
<el-col :span="4">
- <router-link to="/shuffleserverpage/activeNodeList">
+ <router-link class="router-link-active"
to="/shuffleserverpage/activeNodeList">
<el-card class="box-card" shadow="hover">
<template #header>
<div class="card-header">
@@ -31,7 +31,7 @@
</router-link>
</el-col>
<el-col :span="4">
- <router-link to="/shuffleserverpage/decommissioningNodeList">
+ <router-link class="router-link-active"
to="/shuffleserverpage/decommissioningNodeList">
<el-card class="box-card" shadow="hover">
<template #header>
<div class="card-header">
@@ -45,7 +45,7 @@
</router-link>
</el-col>
<el-col :span="4">
- <router-link to="/shuffleserverpage/decommissionedNodeList">
+ <router-link class="router-link-active"
to="/shuffleserverpage/decommissionedNodeList">
<el-card class="box-card" shadow="hover">
<template #header>
<div class="card-header">
@@ -59,7 +59,7 @@
</router-link>
</el-col>
<el-col :span="4">
- <router-link to="/shuffleserverpage/lostNodeList">
+ <router-link class="router-link-active"
to="/shuffleserverpage/lostNodeList">
<el-card class="box-card" shadow="hover">
<template #header>
<div class="card-header">
@@ -71,7 +71,7 @@
</router-link>
</el-col>
<el-col :span="4">
- <router-link to="/shuffleserverpage/unhealthyNodeList">
+ <router-link class="router-link-active"
to="/shuffleserverpage/unhealthyNodeList">
<el-card class="box-card" shadow="hover">
<template #header>
<div class="card-header">
@@ -83,7 +83,7 @@
</router-link>
</el-col>
<el-col :span="4">
- <router-link to="/shuffleserverpage/excludeNodeList">
+ <router-link class="router-link-active"
to="/shuffleserverpage/excludeNodeList">
<el-card class="box-card" shadow="hover">
<template #header>
<div class="card-header">
@@ -151,13 +151,17 @@ export default {
font-size: larger;
}
+/* Remove the underscore from the route label. */
+.router-link-active {
+ text-decoration: none;
+}
+
.activenode {
font-family: 'Lantinghei SC';
font-style: normal;
font-weight: bolder;
font-size: 30px;
color: green;
- text-decoration: none;
}
.decommissioningnode {
@@ -166,7 +170,6 @@ export default {
font-weight: bolder;
font-size: 30px;
color: #00c4ff;
- text-decoration: none;
}
.decommissionednode {
@@ -175,7 +178,6 @@ export default {
font-weight: bolder;
font-size: 30px;
color: blue;
- text-decoration: none;
}
.lostnode {
@@ -184,7 +186,6 @@ export default {
font-weight: bolder;
font-size: 30px;
color: red;
- text-decoration: none;
}
.unhealthynode {
@@ -193,7 +194,6 @@ export default {
font-weight: bolder;
font-size: 30px;
color: #ff8800;
- text-decoration: none;
}
.excludesnode {
@@ -201,6 +201,5 @@ export default {
font-style: normal;
font-weight: bolder;
font-size: 30px;
- text-decoration: none;
}
</style>
