This is an automated email from the ASF dual-hosted git repository.
maobaolong pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-uniffle.git
The following commit(s) were added to refs/heads/master by this push:
new 10c02cd52 [MINOR] fix(spark-client): Fix NPE while using
DelegationRssShuffleManager in executor (#2237)
10c02cd52 is described below
commit 10c02cd523236f6bddb73cb20576e9d396e8d832
Author: maobaolong <[email protected]>
AuthorDate: Wed Nov 6 09:26:04 2024 +0800
[MINOR] fix(spark-client): Fix NPE while using DelegationRssShuffleManager
in executor (#2237)
### What changes were proposed in this pull request?
Fix NPE while using DelegationRssShuffleManager in executor
### Why are the changes needed?
It can encounter NPE if using DelegationRssShuffleManager in executor
without this PR.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Tested Locally
---
.../java/org/apache/spark/shuffle/DelegationRssShuffleManager.java | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git
a/client-spark/spark3/src/main/java/org/apache/spark/shuffle/DelegationRssShuffleManager.java
b/client-spark/spark3/src/main/java/org/apache/spark/shuffle/DelegationRssShuffleManager.java
index 64dd5449d..bb8ed3a90 100644
---
a/client-spark/spark3/src/main/java/org/apache/spark/shuffle/DelegationRssShuffleManager.java
+++
b/client-spark/spark3/src/main/java/org/apache/spark/shuffle/DelegationRssShuffleManager.java
@@ -289,7 +289,9 @@ public class DelegationRssShuffleManager implements
ShuffleManager {
@Override
public void stop() {
delegate.stop();
- coordinatorClient.close();
+ if (coordinatorClient != null) {
+ coordinatorClient.close();
+ }
}
@Override