(incubator-uniffle) branch master updated: [#2188] fix(client): Fixup timeoutMs for executeTasks in ShuffleWriteClientImpl#sendAppHeartbeat (#2189)

[roryqi]

This is an automated email from the ASF dual-hosted git repository.

roryqi pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-uniffle.git


The following commit(s) were added to refs/heads/master by this push:
     new 0481f210e [#2188] fix(client): Fixup timeoutMs for executeTasks in 
ShuffleWriteClientImpl#sendAppHeartbeat (#2189)
0481f210e is described below

commit 0481f210ec67b7ced167fc30179c35a04340c2f6
Author: xumanbu <jam...@vipshop.com>
AuthorDate: Thu Dec 19 12:00:56 2024 +0800

    [#2188] fix(client): Fixup timeoutMs for executeTasks in 
ShuffleWriteClientImpl#sendAppHeartbeat (#2189)
    
    ### What changes were proposed in this pull request?
    
     Fixup timeoutMs for executeTasks in ShuffleWriteClientImpl#sendAppHeartbeat
    
    ### Why are the changes needed?
    
    The `timeoutMs` in ShuffleWriteClientImpl#sendAppHeartbeat method. The 
timeoutMs for per RPC is similar to the timeoutMs of ThreadUtils#executeTasks` 
for all servers RPC execute, and the logic here is flawed.
    
    Resetting the `timeoutMs` for `ThreadUtils.executeTask`.
    
    Fix: #2188
    
    ### Does this PR introduce _any_ user-facing change?
    No.
    
    ### How was this patch tested?
    
    no need
---
 .../java/org/apache/uniffle/client/impl/ShuffleWriteClientImpl.java     | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git 
a/client/src/main/java/org/apache/uniffle/client/impl/ShuffleWriteClientImpl.java
 
b/client/src/main/java/org/apache/uniffle/client/impl/ShuffleWriteClientImpl.java
index 27c55ac3d..dfd3efe30 100644
--- 
a/client/src/main/java/org/apache/uniffle/client/impl/ShuffleWriteClientImpl.java
+++ 
b/client/src/main/java/org/apache/uniffle/client/impl/ShuffleWriteClientImpl.java
@@ -968,7 +968,7 @@ public class ShuffleWriteClientImpl implements 
ShuffleWriteClient {
           }
           return null;
         },
-        timeoutMs,
+        timeoutMs * allShuffleServers.size() / heartBeatThreadNum,
         "send heartbeat to shuffle server");
     if (coordinatorClient != null) {
       coordinatorClient.scheduleAtFixedRateToSendAppHeartBeat(request);