This is an automated email from the ASF dual-hosted git repository.
zuston pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/uniffle.git
The following commit(s) were added to refs/heads/master by this push:
new 31b443e37 [#2385] fix(server): Concurrent FileSegmentManagedBuffer
release (#2406)
31b443e37 is described below
commit 31b443e371728c7bbf30fede9ffd1d9baae4b1a6
Author: summaryzb <[email protected]>
AuthorDate: Fri Mar 14 15:26:25 2025 +0800
[#2385] fix(server): Concurrent FileSegmentManagedBuffer release (#2406)
### What changes were proposed in this pull request?
Avoid release cachedBuffer, when FileSegmentManagedBuffer release
### Why are the changes needed?
There is no need to invoke release, since the reference of cachedBuffer is
reset, besides this may cause concurrent issue
Fix #2404
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
UT
---
.../org/apache/uniffle/common/netty/buffer/FileSegmentManagedBuffer.java | 1 -
1 file changed, 1 deletion(-)
diff --git
a/common/src/main/java/org/apache/uniffle/common/netty/buffer/FileSegmentManagedBuffer.java
b/common/src/main/java/org/apache/uniffle/common/netty/buffer/FileSegmentManagedBuffer.java
index 16db7c792..2f3e26e0e 100644
---
a/common/src/main/java/org/apache/uniffle/common/netty/buffer/FileSegmentManagedBuffer.java
+++
b/common/src/main/java/org/apache/uniffle/common/netty/buffer/FileSegmentManagedBuffer.java
@@ -108,7 +108,6 @@ public class FileSegmentManagedBuffer extends ManagedBuffer
{
@Override
public ManagedBuffer release() {
- cachedBuffer.clear();
cachedBuffer = null;
isFilled = false;
return this;