This is an automated email from the ASF dual-hosted git repository.

rickyma pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/uniffle.git


The following commit(s) were added to refs/heads/master by this push:
     new 94e211c4d [MINOR] Eliminate the usage of the shaded Guava Sets class 
(#2432)
94e211c4d is described below

commit 94e211c4d8c99e4fe1faa8db2b10d21ba0320afd
Author: Andras Salamon <[email protected]>
AuthorDate: Sat Apr 5 13:30:03 2025 +0200

    [MINOR] Eliminate the usage of the shaded Guava Sets class (#2432)
    
    ### What changes were proposed in this pull request?
    
    Replacing shaded guava's `Sets` class usage with `HashSet`
    
    ### Why are the changes needed?
    
    Hadoop can throw this error if the classpath is not correctly set:
    ```
    org.apache.uniffle.client.impl.ShuffleWriteClientImpl: Unexpected 
exceptions occurred while sending shuffle data
    java.util.concurrent.CompletionException: java.lang.NoClassDefFoundError: 
org/apache/hbase/thirdparty/org/glassfish/jersey/internal/guava/Sets
            at 
java.util.concurrent.CompletableFuture.encodeThrowable(CompletableFuture.java:273)
    ```
    
    ### Does this PR introduce _any_ user-facing change?
    
    No.
    
    ### How was this patch tested?
    
    UTs.
---
 .../apache/uniffle/client/impl/grpc/ShuffleServerGrpcNettyClient.java | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git 
a/internal-client/src/main/java/org/apache/uniffle/client/impl/grpc/ShuffleServerGrpcNettyClient.java
 
b/internal-client/src/main/java/org/apache/uniffle/client/impl/grpc/ShuffleServerGrpcNettyClient.java
index 78732733b..e48233ddb 100644
--- 
a/internal-client/src/main/java/org/apache/uniffle/client/impl/grpc/ShuffleServerGrpcNettyClient.java
+++ 
b/internal-client/src/main/java/org/apache/uniffle/client/impl/grpc/ShuffleServerGrpcNettyClient.java
@@ -18,6 +18,7 @@
 package org.apache.uniffle.client.impl.grpc;
 
 import java.util.ArrayList;
+import java.util.HashSet;
 import java.util.List;
 import java.util.Map;
 import java.util.Set;
@@ -26,7 +27,6 @@ import java.util.concurrent.atomic.AtomicReference;
 
 import com.google.common.annotations.VisibleForTesting;
 import org.apache.commons.lang3.tuple.Pair;
-import org.apache.hbase.thirdparty.org.glassfish.jersey.internal.guava.Sets;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
@@ -142,7 +142,7 @@ public class ShuffleServerGrpcNettyClient extends 
ShuffleServerGrpcClient {
     int stageAttemptNumber = request.getStageAttemptNumber();
     boolean isSuccessful = true;
     AtomicReference<StatusCode> failedStatusCode = new 
AtomicReference<>(StatusCode.INTERNAL_ERROR);
-    Set<Integer> needSplitPartitionIds = Sets.newHashSet();
+    Set<Integer> needSplitPartitionIds = new HashSet<>();
     for (Map.Entry<Integer, Map<Integer, List<ShuffleBlockInfo>>> stb :
         shuffleIdToBlocks.entrySet()) {
       int shuffleId = stb.getKey();

Reply via email to