juripetersen commented on PR #385:
URL: https://github.com/apache/incubator-wayang/pull/385#issuecomment-1842205507
@kbeedkar the `PostgresFilterOperator` uses the `sqlImplementation` and the
executor only compiles this "hardcoded" information into the desired SQL query
string. This can be seen in the JDBC `FunctionCompiler`:
```java
public class FunctionCompiler {
/**
* Compile a predicate to a SQL {@code WHERE} clause.
*
* @param descriptor describes the predicate
* @return a compiled SQL {@code WHERE} clause
*/
public String compile(PredicateDescriptor descriptor) {
final String sqlImplementation = descriptor.getSqlImplementation();
assert sqlImplementation != null;
return sqlImplementation;
}
}
```
This is also where the currently proposed solution of this PR was inspired
from. @zkaoudi and I were discussing an approach to avoid this and actually
use a generic interface in Joins. However, this seems to be non-trivial and is
likely to break backwards compatibility.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
