juripetersen commented on code in PR #468: URL: https://github.com/apache/incubator-wayang/pull/468#discussion_r1754314686
########## env_template.sh: ########## @@ -0,0 +1,40 @@ +#!/usr/bin/env bash + +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# +export BOOTSTRAP_SERVER= ... +export CLUSTER_API_KEY= ... +export CLUSTER_API_SECRET= ... +export SR_ENDPOINT= ... +export SR_API_KEY= ... +export SR_API_SECRET= ... +export SCHEMA_REGISTRY_BASIC_AUTH_USER_INFO=" ... : .... " +export SCHEMA_REGISTRY_URL="https://.... " + +export SPARK_HOME=/opt/homebrew/Cellar/apache-spark/3.5.2/libexec Review Comment: This seems to be mac os specific. Maybe also make it an argument or `...` ########## env_template.sh: ########## @@ -0,0 +1,40 @@ +#!/usr/bin/env bash + +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# +export BOOTSTRAP_SERVER= ... +export CLUSTER_API_KEY= ... +export CLUSTER_API_SECRET= ... +export SR_ENDPOINT= ... +export SR_API_KEY= ... +export SR_API_SECRET= ... +export SCHEMA_REGISTRY_BASIC_AUTH_USER_INFO=" ... : .... " +export SCHEMA_REGISTRY_URL="https://.... " + +export SPARK_HOME=/opt/homebrew/Cellar/apache-spark/3.5.2/libexec +export HADOOP_HOME=/opt/homebrew/Cellar/hadoop/3.4.0/libexec Review Comment: This seems to be mac os specific. Maybe also make it an argument or ... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
