github-actions[bot] opened a new issue, #545:
URL: https://github.com/apache/incubator-wayang/issues/545

   needs withSqlImplementation() for sql support
   
   
https://github.com/apache/incubator-wayang/blob/91573ae1ed819f0ff5514f405e504c5ab1cf508e/wayang-api/wayang-api-sql/src/main/java/org/apache/wayang/api/sql/calcite/converter/WayangMultiConditionJoinVisitor.java#L148
   
   ```java
   
   /*
    * Licensed to the Apache Software Foundation (ASF) under one
    * or more contributor license agreements.  See the NOTICE file
    * distributed with this work for additional information
    * regarding copyright ownership.  The ASF licenses this file
    * to you under the Apache License, Version 2.0 (the
    * "License"); you may not use this file except in compliance
    * with the License.  You may obtain a copy of the License at
    *
    *     http://www.apache.org/licenses/LICENSE-2.0
    *
    * Unless required by applicable law or agreed to in writing, software
    * distributed under the License is distributed on an "AS IS" BASIS,
    * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    * See the License for the specific language governing permissions and
    * limitations under the License.
    */
   
   package org.apache.wayang.api.sql.calcite.converter;
   
   import java.io.Serializable;
   import java.util.List;
   import java.util.stream.Collectors;
   import org.apache.calcite.rel.core.Join;
   import org.apache.calcite.rex.RexCall;
   import org.apache.calcite.rex.RexInputRef;
   import org.apache.calcite.rex.RexNode;
   import 
org.apache.wayang.api.sql.calcite.converter.functions.MultiConditionJoinFuncImpl;
   import 
org.apache.wayang.api.sql.calcite.converter.functions.MultiConditionJoinKeyExtractor;
   import org.apache.wayang.api.sql.calcite.rel.WayangJoin;
   import org.apache.wayang.basic.data.Record;
   import org.apache.wayang.basic.data.Tuple2;
   import org.apache.wayang.basic.operators.JoinOperator;
   import org.apache.wayang.basic.operators.MapOperator;
   import org.apache.wayang.core.function.TransformationDescriptor;
   import 
org.apache.wayang.core.function.FunctionDescriptor.SerializableFunction;
   import org.apache.wayang.core.plan.wayangplan.Operator;
   import org.apache.wayang.core.util.ReflectionUtils;
   
   public class WayangMultiConditionJoinVisitor extends 
WayangRelNodeVisitor<WayangJoin> implements Serializable {
   
       /**
        * Visitor that visits join statements that has multiple conditions like:
        * AND(=($1,$2),=($2,$3))
        * Note that this doesnt support nway joins or multijoins.
        * 
        * @param wayangRelConverter
        */
       WayangMultiConditionJoinVisitor(final WayangRelConverter 
wayangRelConverter) {
           super(wayangRelConverter);
       }
   
       @Override
       Operator visit(WayangJoin wayangRelNode) {
           final Operator childOpLeft = 
wayangRelConverter.convert(wayangRelNode.getInput(0));
           final Operator childOpRight = 
wayangRelConverter.convert(wayangRelNode.getInput(1));
           final RexNode condition = ((Join) wayangRelNode).getCondition();
           final RexCall call = (RexCall) condition;
   
           //
           final List<RexCall> subConditions = call.operands.stream()
                   .map(RexCall.class::cast)
                   .collect(Collectors.toList());
   
           // calcite generates the RexInputRef indexes via looking at the union
           // field list of the left and right input of a join.
           // since the left input is always the first in this joined field list
           // we can eagerly get the fields in the left input
           final List<RexInputRef> leftTableInputRefs = subConditions.stream()
                   .map(sub -> sub.getOperands().stream()
                           .map(RexInputRef.class::cast)
                           .min((left, right) -> 
Integer.compare(left.getIndex(), right.getIndex()))
                           .get())
                   .collect(Collectors.toList());
   
           final Integer[] leftTableKeyIndexes = leftTableInputRefs.stream()
                   .map(RexInputRef::getIndex)
                   .toArray(Integer[]::new);
   
           // for the right table input refs, the indexes are offset by the 
amount of rows
           // in the left
           // input to the join
           final List<RexInputRef> rightTableInputRefs = subConditions.stream()
                   .map(sub -> sub.getOperands().stream()
                           .map(RexInputRef.class::cast)
                           .max((left, right) -> 
Integer.compare(left.getIndex(), right.getIndex()))
                           .get())
                   .collect(Collectors.toList());
   
           final Integer[] rightTableKeyIndexes = rightTableInputRefs.stream()
                   .map(RexInputRef::getIndex)
                   .map(key -> key - 
wayangRelNode.getLeft().getRowType().getFieldCount()) // apply offset
                   .toArray(Integer[]::new);
   
           /*
           final List<RelDataTypeField> leftFields = 
Arrays.stream(leftTableKeyIndexes)
                   .map(key -> 
wayangRelNode.getLeft().getRowType().getFieldList().get(key))
                   .collect(Collectors.toList());
   
           final List<RelDataTypeField> rightFields = 
Arrays.stream(rightTableKeyIndexes)
                   .map(key -> 
wayangRelNode.getRight().getRowType().getFieldList().get(key))
                   .collect(Collectors.toList());
   
           final String joiningTableName = childOpLeft instanceof 
WayangTableScan ? childOpLeft.getName() : childOpRight.getName();
           */
           
           // if join is joining the LHS of a join condition "JOIN left ON left 
= right"
           // then we pick the first case, otherwise the 2nd "JOIN right ON 
left = right"
           final JoinOperator<Record, Record, Record> join = 
this.getJoinOperator(
                   leftTableKeyIndexes,
                   rightTableKeyIndexes,
                   wayangRelNode,
                   "",
                   "",
                   "",
                   "");
   
           childOpLeft.connectTo(0, join, 0);
           childOpRight.connectTo(0, join, 1);
   
           // Join returns Tuple2 - map to a Record
           final SerializableFunction<Tuple2<Record, Record>, Record> mp = new 
MultiConditionJoinFuncImpl();
   
           final MapOperator<Tuple2<Record, Record>, Record> mapOperator = new 
MapOperator<Tuple2<Record, Record>, Record>(
                   mp,
                   ReflectionUtils.specify(Tuple2.class),
                   Record.class);
   
           join.connectTo(0, mapOperator, 0);
   
           return mapOperator;
       }
   
       /**
        * This method handles the {@link JoinOperator} creation, used in 
conjunction
        * with:
        * {@link #determineKeyExtractionDirection(Integer, Integer, WayangJoin)}
        * 
        * @param wayangRelNode
        * @param leftKeyIndex
        * @param rightKeyIndex
        * @return a {@link JoinOperator} with {@link KeyExtractors} set
        */
       protected JoinOperator<Record, Record, Record> getJoinOperator(final 
Integer[] leftKeyIndexes,
               final Integer[] rightKeyIndexes,
               final WayangJoin wayangRelNode, final String leftTableName, 
final String leftFieldNames,
               final String rightTableName, final String rightFieldNames) {
           // TODO: needs withSqlImplementation() for sql support
   
           if (wayangRelNode.getInputs().size() != 2)
               throw new UnsupportedOperationException("Join had an unexpected 
amount of inputs, found: "
                       + wayangRelNode.getInputs().size() + ", expected: 2");
   
           final TransformationDescriptor<Record, Record> 
leftProjectionDescriptor = new TransformationDescriptor<Record, Record>(
                   new MultiConditionJoinKeyExtractor(leftKeyIndexes),
                   Record.class, Record.class);
           // .withSqlImplementation(""," ")
   
           final TransformationDescriptor<Record, Record> 
rightProjectionDescriptor = new TransformationDescriptor<Record, Record>(
                   new MultiConditionJoinKeyExtractor(rightKeyIndexes),
                   Record.class, Record.class);
           // .withSqlImplementation(""," ")
   
           final JoinOperator<Record, Record, Record> join = new JoinOperator<>(
                   leftProjectionDescriptor,
                   rightProjectionDescriptor);
   
           return join;
       }
   }
   
   ```
   
   7a3b3b609100dbe84fed976a2a59e971bd27a217


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to