xristlamp commented on code in PR #570:
URL: https://github.com/apache/incubator-wayang/pull/570#discussion_r2097781628
##########
python/src/pywy/basic/model/models.py:
##########
@@ -27,3 +27,10 @@ def __init__(self, out: Op):
def get_out(self):
return self.out
+
+class LogisticRegression(Op):
+ def __init__(self, name=None):
+ super().__init__(Op.DType.FLOAT32, name)
+
+ def inputs_required(self):
Review Comment:
You're right ! I removed the inputs_required method from the
LogisticRegression class and re-ran the tests. Everything works perfectly
without it, so it seems it's not needed in this case. Thanks for pointing it
out!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
