xristlamp commented on PR #576: URL: https://github.com/apache/incubator-wayang/pull/576#issuecomment-2910156806
Hi @mspruc , @zkaoudi , thank you both for your helpful feedback! You're absolutely right, the operator should not return Void. I have updated the implementation to align with the design pattern used in LinearRegressionOperator. Here's what's been changed: - The third type parameter of BinaryToUnaryOperator is now DecisionTreeRegressionModel instead of Void. - The operator now returns the trained model, not just the predictions. - The SparkDecisionTreeRegressionOperator wraps the Spark MLlib model and implements the DecisionTreeRegressionModel interface, just like the linear regression case. - The DSL API and tests were also updated to reflect the correct model return type. This ensures the operator follows the same interface contract as the other regression operators in Wayang, and allows for post-training model usage. Appreciate the guidance! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
