juripetersen commented on code in PR #646:
URL: https://github.com/apache/incubator-wayang/pull/646#discussion_r2622050562
##########
wayang-api/wayang-api-scala-java/src/main/scala/org/apache/wayang/api/DataQuanta.scala:
##########
@@ -1027,6 +1027,12 @@ class DataQuanta[Out: ClassTag](val operator:
ElementaryOperator, outputIndex: I
writeTextFileJava(url, toSerializableFunction(formatterUdf), udfLoad)
}
+ def writeParquet(url: String, overwrite: Boolean = false)(implicit ev: Out
=:= Record): Unit =
+ writeParquetJava(url, overwrite, preferDataset = false)
+
+ def writeParquetAsDataset(url: String, overwrite: Boolean = true)(implicit
ev: Out =:= Record): Unit =
Review Comment:
Is it nicer for the API here if `writeParquet` gets a `preferDataset`
parameter that is false by default?
This would allow to remove `writeParquetAsDataset` altogether.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
