juripetersen commented on code in PR #656:
URL: https://github.com/apache/wayang/pull/656#discussion_r2689366672
##########
wayang-api/wayang-api-scala-java/src/main/scala/org/apache/wayang/api/DataQuanta.scala:
##########
@@ -1027,6 +1026,44 @@ class DataQuanta[Out: ClassTag](val operator:
ElementaryOperator, outputIndex: I
writeTextFileJava(url, toSerializableFunction(formatterUdf), udfLoad)
}
+ /**
+ * Write the data quanta in this instance to a iceberg table. Triggers
execution.
+ *
+ * @param catalog Iceberg Catalog
+ * @param schema Iceberg Schema of the table to create
+ * @param tableIdentifier Iceberg Table Identifier of the table to create
+ * @param outputFileFormat File format of the output data files
+ */
+
+ def writeIcebergTable(catalog: org.apache.iceberg.catalog.Catalog,
Review Comment:
Are there multiple imports of `Catalog` here, or why is the full name
needed?
Ideally, you would import this at the top of the file and use the class name
here instead of the full namespace for all of the iceberg imports.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
