zkaoudi commented on code in PR #718:
URL: https://github.com/apache/wayang/pull/718#discussion_r2971700858
##########
wayang-benchmark/src/main/java/org/apache/wayang/apps/wordcount/WordCountParquet.java:
##########
@@ -37,7 +37,7 @@ public static void main(String[] args){
System.exit(1);
}
- WayangContext wayangContext = new WayangContext();
+ WayangContext wayangContext = new WayangContext(new Configuration());
Review Comment:
same here
##########
wayang-benchmark/src/main/java/org/apache/wayang/apps/wordcount/WordCountWithPlanBuilder.java:
##########
@@ -0,0 +1,116 @@
+/*
Review Comment:
There is already a Wordcount with the planbuilder so we do not need a second
benchmark.
See here:
https://github.com/apache/wayang/blob/main/wayang-benchmark/src/main/java/org/apache/wayang/apps/wordcount/WordCount.java
##########
wayang-benchmark/src/main/java/org/apache/wayang/apps/wordcount/Main.java:
##########
@@ -46,7 +39,7 @@ public static void main(String[] args) throws IOException,
URISyntaxException {
System.exit(1);
}
- WayangContext wayangContext = new WayangContext();
+ WayangContext wayangContext = new WayangContext(new
Configuration());
Review Comment:
What's the purpose of adding an empty configuration in the context?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
