AjayBoddeda4 commented on issue #732: URL: https://github.com/apache/wayang/issues/732#issuecomment-4119784329
Hi Carlo, thank you for flagging this. I was looking at ProjectionDescriptor while studying the codebase for the DataFrame API proposal. The inputType parameter appears to be passed in but never used in the method body — the implementation only uses fieldNames to create the PojoImplementation. One possible fix would be to either remove the inputType parameter entirely if it is not needed, or use it to add type validation before the projection — for example checking that the input type actually has the requested field. This would make the DataFrame API's select() operation more robust when users specify column names. Would love to contribute a fix for this if guidance is provided on the preferred approach! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
