mohit-devlogs commented on code in PR #708:
URL: https://github.com/apache/wayang/pull/708#discussion_r3311070680
##########
wayang-platforms/wayang-generic-jdbc/src/main/java/org/apache/wayang/genericjdbc/operators/GenericSqlToStreamOperator.java:
##########
@@ -86,40 +75,58 @@ public Tuple<Collection<ExecutionLineageNode>,
Collection<ChannelInstance>> eval
ChannelInstance[] outputs,
JavaExecutor executor,
OptimizationContext.OperatorContext operatorContext) {
- // Cast the inputs and outputs.
+
final SqlQueryChannel.Instance input = (SqlQueryChannel.Instance)
inputs[0];
final StreamChannel.Instance output = (StreamChannel.Instance)
outputs[0];
- GenericJdbcPlatform producerPlatform = (GenericJdbcPlatform)
input.getChannel().getProducer().getPlatform();
+ GenericJdbcPlatform producerPlatform =
+ (GenericJdbcPlatform)
input.getChannel().getProducer().getPlatform();
+
+ // Fix: safely resolve JDBC name
Review Comment:
Removed the unnecessary comment and cleaned up the related section
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]