JunWang222 commented on code in PR #787:
URL: https://github.com/apache/wayang/pull/787#discussion_r3792523743
##########
wayang-tests-integration/src/test/java/org/apache/wayang/tests/FlinkIntegrationIT.java:
##########
@@ -314,12 +314,13 @@ void
testReadAndTransformAndWriteWithIllegalConfiguration3() {
// Build a Wayang plan.
final WayangPlan wayangPlan =
WayangPlans.readTransformWrite(WayangPlans.FILE_SOME_LINES_TXT);
- // Instantiate Wayang and activate the Spark backend.
+ // Instantiate Wayang and activate the Java/Flink backends.
WayangContext wayangContext = makeContext(FLINK);
// Have Wayang execute the plan.
final Job job = wayangContext.createJob(null, wayangPlan);
- // ILLEGAL: We blacklist the Spark platform, although we need it.
+ // ILLEGAL: We blacklist all platforms that can execute the plan.
+
job.getConfiguration().getPlatformProvider().addToBlacklist(Java.platform());
Review Comment:
The intention of this test is to register both Java and Flink, then
blacklist both executable platforms so that only the made-up platform remains
and the job fails as expected. I will make this explicit by changing the
context setup from makeContext(FLINK) to makeContext(BOTH).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
