novatechflow commented on PR #806: URL: https://github.com/apache/wayang/pull/806#issuecomment-6396038018
Great progress - you picked a really tricky one, btw. One remaining part: plugin registration ignores explicit settings on `Configuration.getDefaultConfiguration()` when configuring a child. Reproduce with Java 17: set the global model path to `/custom/global.onnx`, create a child configuration, then register the plugin, the child gets the bundled model path instead. When reading the code I think the hierarchy scan stops before checking the global configuration. It should include that level’s explicit properties and add a regression test. Thoughts? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
