novatechflow commented on PR #839: URL: https://github.com/apache/wayang/pull/839#issuecomment-6396093917
Ran a short test together with the other review, also great progress. Mixed quoting is fixed; the locale bug remains: the code still uses parameterless `toUpperCase()` / `toLowerCase()`. Both need `Locale.ROOT`, plus a Turkish-locale regression test. My locale test found only Turkish, not sure if we also hit others. So `locale.ROOT` seems the best solution. We can't assume that users set their console to English. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
