JunWang222 commented on code in PR #793:
URL: https://github.com/apache/wayang/pull/793#discussion_r4394525777
##########
wayang-platforms/wayang-jdbc-template/src/main/java/org/apache/wayang/jdbc/execution/JdbcExecutor.java:
##########
@@ -154,93 +172,106 @@ protected static Tuple2<String,
SqlQueryChannel.Instance> createSqlQuery(final E
assert allTasks.size() <= 3;
ExecutionTask nextTask =
JdbcExecutor.findJdbcExecutionOperatorTaskInStage(startTask, stage);
while (nextTask != null) {
- // Evaluate the nextTask.
final ExecutionOperator operator = nextTask.getOperator();
if (operator instanceof FilterOperator || operator instanceof
SpatialFilterOperator) {
filterTasks.add((JdbcExecutionOperator) operator);
} else if (operator instanceof JdbcProjectionOperator) {
- assert projectionTask == null; // Allow one projection
operator per stage for now.
+ assert projectionTask == null;
projectionTask = (JdbcProjectionOperator) operator;
} else if (operator instanceof final JdbcGlobalReduceOperator
globalReduce) {
- assert globalReduceTask == null; // Allow one projection
operator per stage for now.
+ assert globalReduceTask == null;
globalReduceTask = globalReduce;
} else if (operator instanceof final JdbcReduceByOperator
reduceBy) {
- assert reduceByTask == null; // Allow one projection operator
per stage for now.
Review Comment:
Thanks for pointing this out. These comments were removed unintentionally
during the refactoring. I’ve restored them and updated them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]