Repository: incubator-weex
Updated Branches:
  refs/heads/0.12-dev 58eaa9d85 -> a8ad8af33


* [android] fix wrong type to detect list child


Project: http://git-wip-us.apache.org/repos/asf/incubator-weex/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-weex/commit/a8ad8af3
Tree: http://git-wip-us.apache.org/repos/asf/incubator-weex/tree/a8ad8af3
Diff: http://git-wip-us.apache.org/repos/asf/incubator-weex/diff/a8ad8af3

Branch: refs/heads/0.12-dev
Commit: a8ad8af3301a3c22e2ba3110af56f413dad8ab1a
Parents: 58eaa9d
Author: sospartan <[email protected]>
Authored: Wed May 10 11:48:55 2017 +0800
Committer: sospartan <[email protected]>
Committed: Wed May 10 11:48:55 2017 +0800

----------------------------------------------------------------------
 .../taobao/weex/ui/component/list/BasicListComponent.java    | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-weex/blob/a8ad8af3/android/sdk/src/main/java/com/taobao/weex/ui/component/list/BasicListComponent.java
----------------------------------------------------------------------
diff --git 
a/android/sdk/src/main/java/com/taobao/weex/ui/component/list/BasicListComponent.java
 
b/android/sdk/src/main/java/com/taobao/weex/ui/component/list/BasicListComponent.java
index 9c869f4..efe9147 100644
--- 
a/android/sdk/src/main/java/com/taobao/weex/ui/component/list/BasicListComponent.java
+++ 
b/android/sdk/src/main/java/com/taobao/weex/ui/component/list/BasicListComponent.java
@@ -315,7 +315,7 @@ public abstract class BasicListComponent<T extends 
ViewGroup & ListComponentView
       return null;
     }
 
-    if (parent instanceof WXListComponent) {
+    if (parent instanceof BasicListComponent) {
       return comp;
     }
 
@@ -551,7 +551,7 @@ public abstract class BasicListComponent<T extends 
ViewGroup & ListComponentView
   }
 
   /**
-   * Append a child component to the end of WXListComponent. This will not 
refresh the underlying
+   * Append a child component to the end of list. This will not refresh the 
underlying
    * view immediately. The message of index of the inserted child is given to 
the adapter, and the
    * adapter will determine when to refresh. The default implementation of 
adapter will push the
    * message into a message and refresh the view in a period of time.
@@ -661,7 +661,7 @@ public abstract class BasicListComponent<T extends 
ViewGroup & ListComponentView
   }
 
   /**
-   * Remove the child from WXListComponent. This method will use {@link
+   * Remove the child from list. This method will use {@link
    * java.util.List#indexOf(Object)} to retrieve the component to be deleted. 
Like {@link
    * #addChild(WXComponent)}, this method will not refresh the view 
immediately, the adapter will
    * decide when to refresh.
@@ -743,7 +743,7 @@ public abstract class BasicListComponent<T extends 
ViewGroup & ListComponentView
    * Bind the component of the position to the holder. Then flush the view.
    *
    * @param holder   viewHolder, which holds reference to the view
-   * @param position position of component in WXListComponent
+   * @param position position of component in list
    */
   @Override
   public void onBindViewHolder(ListBaseViewHolder holder, int position) {

Reply via email to