Github user acton393 commented on a diff in the pull request:

    https://github.com/apache/incubator-weex/pull/754#discussion_r141800529
  
    --- Diff: ios/sdk/WeexSDK/Sources/Module/WXWebSocketModule.m ---
    @@ -126,7 +126,7 @@ - (void)close
     
     - (void)close:(NSString *)code reason:(NSString *)reason
     {
    -    if(!code)
    +    if([WXUtility isBlankString:code])
    --- End diff --
    
    there is a assert crash  when code is empty string but not a nil value


---

Reply via email to