YorkShen commented on a change in pull request #1816: [WEEX-669][android] fix slider crash when adapter is null URL: https://github.com/apache/incubator-weex/pull/1816#discussion_r236151536
########## File path: android/sdk/src/main/java/com/taobao/weex/ui/component/WXSlider.java ########## @@ -214,7 +214,14 @@ public void run() { @Override public void setLayout(WXComponent component) { - mAdapter.setLayoutDirectionRTL(this.isNativeLayoutRTL()); + if (TextUtils.isEmpty(component.getComponentType()) Review comment: ``` WXComponent.java public static void setLayoutSafe(Component ){ if Check setLayout(Component) } proctected void setLayout(Component ){ //Remove if check } ``` Make sure codes in weex_sdk invoke setLayoutSafe ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services