This is an automated email from the ASF dual-hosted git repository.

sebb pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/whimsy.git


The following commit(s) were added to refs/heads/master by this push:
     new d9c6eb4  Eliminate unused variable warning (and clarify code)
d9c6eb4 is described below

commit d9c6eb4793258d834791e0094eb443ccae4f6216
Author: Sebb <[email protected]>
AuthorDate: Sun Jan 12 22:48:17 2020 +0000

    Eliminate unused variable warning (and clarify code)
---
 lib/whimsy/asf/ldap.rb | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/lib/whimsy/asf/ldap.rb b/lib/whimsy/asf/ldap.rb
index 28b32d2..f0e4969 100644
--- a/lib/whimsy/asf/ldap.rb
+++ b/lib/whimsy/asf/ldap.rb
@@ -1028,8 +1028,7 @@ module ASF
 
     # return a list of ids who are members of this group
     def memberids
-      # members looks like a variable, but it's not, so don't drop it
-      members = weakref(:members) do
+      self.members = weakref(:members) do
         ASF.search_one(base, "cn=#{name}", 'memberUid').flatten
       end
     end

Reply via email to