This is an automated email from the ASF dual-hosted git repository.
sebb pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/whimsy.git
The following commit(s) were added to refs/heads/master by this push:
new a0ee864d Should not happen
a0ee864d is described below
commit a0ee864d2369fb04e123cd8fb70dd3c1737904dd
Author: Sebb <[email protected]>
AuthorDate: Sun Jan 14 22:49:25 2024 +0000
Should not happen
---
www/committers/subscribe.cgi | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/www/committers/subscribe.cgi b/www/committers/subscribe.cgi
index deb4b72b..397d5a7f 100755
--- a/www/committers/subscribe.cgi
+++ b/www/committers/subscribe.cgi
@@ -247,11 +247,11 @@ _html do
Dir.mktmpdir do |tmpdir|
# commit using user's credentials if possible, otherwise use whisysvn
- if not $PASSWORD
- credentials = {}
+ if not $PASSWORD # should not happen
+ raise ArgumentError.new "Missing credentials"
elsif user.asf_member?
credentials = {user: $USER, password: $PASSWORD}
- else
+ else # committer has insufficient karma, use the proxy
credentials = {user: 'whimsysvn'}
end
