(whimsy) branch master updated: Optional attributes do not work; not actually used

[sebb]

This is an automated email from the ASF dual-hosted git repository.

sebb pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/whimsy.git


The following commit(s) were added to refs/heads/master by this push:
     new 7e4fa31c Optional attributes do not work; not actually used
7e4fa31c is described below

commit 7e4fa31c87e9a71c33de399b021905f430b04d52
Author: Sebb <s...@apache.org>
AuthorDate: Tue Mar 19 12:51:04 2024 +0000

    Optional attributes do not work; not actually used
    
    See ASF::Person.preload
---
 lib/whimsy/asf/ldap.rb | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/whimsy/asf/ldap.rb b/lib/whimsy/asf/ldap.rb
index 259cf266..348c5dbb 100644
--- a/lib/whimsy/asf/ldap.rb
+++ b/lib/whimsy/asf/ldap.rb
@@ -680,8 +680,8 @@ module ASF
 
     # Obtain a list of people known to LDAP.  LDAP filters may be used
     # to retrieve only a subset.
-    def self.list(filter='uid=*', attributes='uid')
-      ASF.search_one(base, filter, attributes).flatten.map {|uid| find(uid)}
+    def self.list(filter='uid=*')
+      ASF.search_one(base, filter, 'uid').flatten.map {|uid| find(uid)}
     end
 
     # Obtain a list of people (ids) known to LDAP.  LDAP filters may be used