This is an automated email from the ASF dual-hosted git repository.

sebb pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/whimsy.git


The following commit(s) were added to refs/heads/master by this push:
     new 43bd074d Use library method
43bd074d is described below

commit 43bd074dd8b3bdcb446bb8f1531fa6777ada260d
Author: Sebb <[email protected]>
AuthorDate: Sun Oct 6 12:34:15 2024 +0100

    Use library method
---
 www/secretary/workbench/views/actions/memapp.json.rb | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/www/secretary/workbench/views/actions/memapp.json.rb 
b/www/secretary/workbench/views/actions/memapp.json.rb
index f1499399..e558ebd1 100644
--- a/www/secretary/workbench/views/actions/memapp.json.rb
+++ b/www/secretary/workbench/views/actions/memapp.json.rb
@@ -91,8 +91,7 @@ task 'update cn=member,ou=groups,dc=apache,dc=org in LDAP' do
       _transcript ["#{@availid} already in group member"]
     else
       ASF::LDAP.bind(env.user, env.password) do
-        # TODO there ought to be a library method to do this
-        ASF::LDAP.modify(ASF::Group['member'].dn, 
[ASF::Base.mod_add('memberUid', @availid)])
+        ASF::Group['member'].add(ASF::Person.find(@availid))
       end
     end
   end

Reply via email to