[
https://issues.apache.org/jira/browse/WICKET-1166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12552154
]
Nathan Hamblen commented on WICKET-1166:
----------------------------------------
Good catch! If you have the form with method="get", and then submit by ajax it
throws an exception with this patch. I wonder if adding ajax submit buttons to
a form shouldn't force a method="post", since that is the method that will be
used for ajax regardless? Seems a little confusing to have a GET form that is
actually posted.
I guess it comes down to what getMethod() is supposed to mean, if it's just for
the markup or if it implies how the form is expected and required to be
submitted. If it's just for the markup the method description should probably
not say "the method used to submit the form".
> add sanity check on form submit for request method
> --------------------------------------------------
>
> Key: WICKET-1166
> URL: https://issues.apache.org/jira/browse/WICKET-1166
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.3.0-rc1
> Environment: Safari 3
> Reporter: Nathan Hamblen
> Priority: Minor
> Attachments: submit-method.patch
>
>
> When refreshing a frameset that includes an already POST submitted Wicket
> form in a frame, using the redirect to render strategy, Safari erroneously
> requests the form's original target by GET, rather than the location that was
> eventually redirected to. Therefore none of the form values are available in
> the request object and NPEs will occur trying to access them in places like
> AbstractConverter.java:55.
> Because Form allows for a particular request method to be specified, I think
> it should also confirm that the expected method was used instead of waiting
> for an NPE in validation. The outcome is the same, but the cause of the error
> (the client) would be more evident in server logs, etc. Patch to come...
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
