Author: ivaynberg
Date: Sat Feb  9 12:32:02 2008
New Revision: 620191

URL: http://svn.apache.org/viewvc?rev=620191&view=rev
Log:
WICKET-1294 PrependingStringBuffer.hashCode() doesn't meet its contract

Modified:
    
wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/util/string/PrependingStringBuffer.java
    
wicket/trunk/jdk-1.4/wicket/src/test/java/org/apache/wicket/util/string/PrependingStringBufferTest.java

Modified: 
wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/util/string/PrependingStringBuffer.java
URL: 
http://svn.apache.org/viewvc/wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/util/string/PrependingStringBuffer.java?rev=620191&r1=620190&r2=620191&view=diff
==============================================================================
--- 
wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/util/string/PrependingStringBuffer.java
 (original)
+++ 
wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/util/string/PrependingStringBuffer.java
 Sat Feb  9 12:32:02 2008
@@ -152,6 +152,10 @@
                {
                        return toString().equals(obj.toString());
                }
+       }
 
+       public int hashCode()
+       {
+               return toString().hashCode();
        }
 }

Modified: 
wicket/trunk/jdk-1.4/wicket/src/test/java/org/apache/wicket/util/string/PrependingStringBufferTest.java
URL: 
http://svn.apache.org/viewvc/wicket/trunk/jdk-1.4/wicket/src/test/java/org/apache/wicket/util/string/PrependingStringBufferTest.java?rev=620191&r1=620190&r2=620191&view=diff
==============================================================================
--- 
wicket/trunk/jdk-1.4/wicket/src/test/java/org/apache/wicket/util/string/PrependingStringBufferTest.java
 (original)
+++ 
wicket/trunk/jdk-1.4/wicket/src/test/java/org/apache/wicket/util/string/PrependingStringBufferTest.java
 Sat Feb  9 12:32:02 2008
@@ -70,5 +70,19 @@
                assertTrue(psb.equals(psb));
        }
 
+       /**
+        * Test if implementation of hashCode() meets its <a
+        * 
href="http://java.sun.com/j2se/1.5.0/docs/api/java/lang/Object.html#hashCode()">contract<a>.
+        * 
+        * @throws Exception
+        */
+       public void testHash() throws Exception
+       {
+               PrependingStringBuffer foo = new PrependingStringBuffer("foo");
+               PrependingStringBuffer bar = new PrependingStringBuffer("foo");
+               assertTrue(foo.equals(bar));
+               assertEquals(foo.hashCode(), bar.hashCode());
+       }
+
 
 }


Reply via email to