[ 
https://issues.apache.org/jira/browse/WICKET-1418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12578352#action_12578352
 ] 

Peter Ertl commented on WICKET-1418:
------------------------------------

What's the motivation behind wrapping AbortExceptions?

And, yes, this should indeed happen anywhere you catch RuntimeException...

Pass it, not wrap it

Otherwise you probably would have to change RequestCycle#step() in line 1256 
(current trunk) to unwrap AbortExceptions before processing them


> org.apache.wicket.MarkupContainer swallows AbortException
> ---------------------------------------------------------
>
>                 Key: WICKET-1418
>                 URL: https://issues.apache.org/jira/browse/WICKET-1418
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>            Reporter: Peter Ertl
>            Assignee: Igor Vaynberg
>         Attachments: bugtest.zip, wicket-1418-pertl.patch, wicket-patch
>
>
> MarkupContainer#onBeforeRenderChildren() will catch exceptions of type 
> org.apache.wicket.AbortException and remap them to a WicketRuntimeException. 
> This is obviously wrong.
> For example when throwing a RestartResponseException the exception will be 
> remapped to WicketRuntimeException and the response will not be restarted but 
> the error page will be shown.
> I attached a usecase to demonstrate this bug.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to