JavaScriptStripper breaks prototype.js
---------------------------------------
Key: WICKET-1520
URL: https://issues.apache.org/jira/browse/WICKET-1520
Project: Wicket
Issue Type: Bug
Affects Versions: 1.3.3, 1.3.2
Reporter: Juliano Viana
Fix For: 1.3.4
JavaScriptStripper is used to strip whitespace and comments from JavaScript
files if the resource settings for the application enable that behavior.
The problem is it breaks prototype.js version 1.6.0 (a heavily used JavaScript
library, used by many components like wicketstuff-scriptaculous ).
It changes the library so that the line that reads:
document.write("<script id=__onDOMContentLoaded defer src=//:><\/script>");
becomes:
document.write("<script id=__onDOMContentLoaded defer src=
This is enough to render useless any application that relies on scriptaculous .
The funny part is that it only happen if the application mode is DEPLOYMENT, as
in DEVELOPMENT this code is not active.
I suggest dropping this functionality altogether - the logic for doing the
stripping is extremely complicated and what is the point of stripping
whitespace and comments from something that is going to be gzip compressed
anyway?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
