[ 
https://issues.apache.org/jira/browse/WICKET-1220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12643983#action_12643983
 ] 

Igor Vaynberg commented on WICKET-1220:
---------------------------------------

i dont care which way we go but this issue has been open for a long time. you 
want roll it back and rename the method.

as far as i can see findparent() doesnt check the current class, but properly 
starts with the parent.

i think its really stupid that visitparents visits the current component, so -1 
on just updating the javadocs. either leave it or rename the method.

> Component.visitParents visits the calling component as well
> -----------------------------------------------------------
>
>                 Key: WICKET-1220
>                 URL: https://issues.apache.org/jira/browse/WICKET-1220
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.3.0-rc1
>         Environment: Windows XP, JDK 1.5.0_10
>            Reporter: Bart Molenkamp
>            Assignee: Igor Vaynberg
>             Fix For: 1.4-M4
>
>
> I see that Component.visitParents() also visits the component on which the 
> call is made. Is this behavior correct?
> If so, I think that the method name is a little bit confusing. The method 
> MarkupContainer.visitChildren() doesn't visit the calling component, but only 
> it's children (as the method name suggests).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to