[
https://issues.apache.org/jira/browse/WICKET-2127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12679120#action_12679120
]
knopp edited comment on WICKET-2127 at 3/5/09 2:34 AM:
-------------------------------------------------------------
This one
var replaceAll = function(str, from, to) {
eval(
'var regex = /' + from.replace( /\W/g ,'\\$&' ) + '/g ;'
);
return str.replace(regex,to);
}
looks good to me. I will apply it to 1.4 and if no one complains after some
time I will probably also add it to 1.3.
was (Author: knopp):
This one
var replaceAll = function(str, from, to) {
eval(
'var regex = /' + from.replace( /\W/g ,'\\$&' ) + '/g ;'
);
return str.replace(regex,to);
}
looks good to me. I will apply it to 1.4 and if no one complains after same
time I will probably also add it to 1.3.
> Javascript function Wicket.replaceAll is unbearably slow
> --------------------------------------------------------
>
> Key: WICKET-2127
> URL: https://issues.apache.org/jira/browse/WICKET-2127
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.4-RC2
> Environment: Firefox 3.0.5, Opera 9.2 (windows)
> Reporter: Sean Patrick Floyd
> Assignee: Matej Knopp
> Fix For: 1.4-RC3
>
> Attachments: wicketReplaceAll.js
>
> Original Estimate: 0.5h
> Remaining Estimate: 0.5h
>
> I use AbstractAjaxTimerBehavior to update many different components on my
> pages periodically.
> After a while, the browser occupies 50% or more of the system resources.
> I used the javascript profiler in firebug and found that Wicket.replaceAll is
> responsible for 60+ percent of javascript processing time.
> The problem is that sequential string processing is used instead of much
> faster regular expressions
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
