[ 
https://issues.apache.org/jira/browse/WICKET-2137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12681600#action_12681600
 ] 

James Carman commented on WICKET-2137:
--------------------------------------

I've deleted my patch.  I guess I didn't have all the necessary files in my 
"change list" in IDEA for this issue.  Sorry for the mix-up.  However, I'm 
working on a more pervasive change to the API that changes *all* instances 
where we have these issues to adhere to my proposal (the more I kept pulling, 
the more I had to change!).  I'm going to create another issue and attach my 
patch there.  If the core devs don't like my API change ideas, they can scrap 
it.  I will also send an email to the users list asking for feedback on the 
proposed changes.  I understand that my proposal doesn't exactly match what 
folks voted on, but I don't think all of the options were on the table at the 
time and the most vocal folks seemed to agree with my idea.  Again, Jeremy, 
sorry for giving you a bad patch and wasting your time.  That was totally my 
bad.

> Synchronize generics between ListView and DropDownChoice
> --------------------------------------------------------
>
>                 Key: WICKET-2137
>                 URL: https://issues.apache.org/jira/browse/WICKET-2137
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>    Affects Versions: 1.4-RC3
>         Environment: 1.4-SNAPSHOT as of 2009-01-28
>            Reporter: Brill Pappin
>         Attachments: TestGenerics.java
>
>
> DropDownChoice has a generics definition of List<? extends T> in its 
> constructor. 
> This causes trouble with existing models that may be used in a DropDownChoice 
> and is not consistant with ListView which uses <List<T>>.
> Change DropDownChoice to match the other list type components so that their 
> models can be used across components.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to