[
https://issues.apache.org/jira/browse/WICKET-2150?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dave Schoorl updated WICKET-2150:
---------------------------------
Attachment: wizard-patch-revised-1.4.x.txt
Johan, please find attached my patch 'wizard-patch-revised-1.4.x.txt' for 1.4.
Form#onSubmit is public there and the Wizard#newForm method is adapted. The
form-implementation returned provides a custom onSubmit flow. Making
Form#onSubmit public causes all overridden implementations of this method in
test cases to be changed to public as well.
Thanks for your cooperative thinking. Reality is always more complex. The app I
am building is highly pluggable and third parties must be able to supply their
own plug-ins. When a page is created, plug-ins can contribute to the page, this
also goes for the views in my Wizards. So basically, I have no control over all
forms that will be placed on the wizard's view. Moreover, every customer that
uses the system can configure the plug-ins that he wants to be activated in his
environment. The app itself is capable of running all these different customer
environments.
But for this moment I will use a custom 1.3-SNAPSHOT of wicket that i have
build locally where the submitted patch is applied. This is a temporary
situation, until I have migrated to Wicket 1.4.
Many thanks again.
> Wizard executes onSubmit() of wrong nested form
> -----------------------------------------------
>
> Key: WICKET-2150
> URL: https://issues.apache.org/jira/browse/WICKET-2150
> Project: Wicket
> Issue Type: Bug
> Components: wicket-extensions
> Affects Versions: 1.3.5, 1.4-RC2
> Reporter: Dave Schoorl
> Fix For: 1.3.6, 1.4-RC3
>
> Attachments: wizard-onsubmit.zip, wizard-patch-1.3.x.txt,
> wizard-patch-1.4.x.txt, wizard-patch-revised-1.3.x.txt,
> wizard-patch-revised-1.4.x.txt
>
>
> When you have a wizard and the steps in the wizard contain nested forms, the
> onSubmit() of the next - instead of the current - step's nested form is
> executed. This is caused by the fact that during the advancing of step A to
> step B, first the view of A is replaced with the view of B on the wizard's
> form, and after that, the form's (and nested form's) onSubmit() is called,
> incorrectly calling the onSubmit() of view B.
> The swapping of the view should happen after the wizard's form (and nested
> forms) onSubmit() has been called.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
