[
https://issues.apache.org/jira/browse/WICKET-2469?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Igor Vaynberg resolved WICKET-2469.
-----------------------------------
Resolution: Fixed
Fix Version/s: 1.5-M1
1.4.2
Assignee: Igor Vaynberg
there is now a new constructor in MultipartServletWebRequest that takes the
factory. btw, its not a good idea to create overridable methods that are called
from constructors.
> Allow using a different FileItemFactory by extracting a method in
> MultipartServletWebRequest class
> --------------------------------------------------------------------------------------------------
>
> Key: WICKET-2469
> URL: https://issues.apache.org/jira/browse/WICKET-2469
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.4.1
> Environment: Anyone
> Reporter: Esteban Masoero
> Assignee: Igor Vaynberg
> Priority: Minor
> Fix For: 1.4.2, 1.5-M1
>
> Attachments: refactor.diff
>
>
> Hi there:
> In MultipartServletWebRequest constructor we have:
> ...
> (line 93) DiskFileItemFactory factory = new DiskFileItemFactory();
> ...
> which inhibits anyone from reusing MultipartServletWebRequest with a
> different factory. The only solution is generate a new class that is a copy
> of this one, with that line changed.
> The suggestion is to extract this code into a protected method, so we could
> just extend this class when there's a need to use a different factory (as in
> GAE applications).
> A diff file is added.
> Thanks in advance,
> Esteban
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
