o.a.wicket.ng.** Resource related classes don't take 'variation' into account 
------------------------------------------------------------------------------

                 Key: WICKET-2571
                 URL: https://issues.apache.org/jira/browse/WICKET-2571
             Project: Wicket
          Issue Type: Improvement
          Components: wicket
    Affects Versions: 1.5-M1
            Reporter: Martin Grigorov
             Fix For: 1.5-M1
         Attachments: wicket-2571.patch

The Resource and ResourceReference related classes in o.a.wicket.ng package 
don't take into account the 'variation'. Several weeks ago Juergen splitted 
'style' and 'variation' in 1.5-SNAPSHOT. It seems Matej have finished the new 
classes before that split.

I'm attaching a patch which includes 'variation' into account.
Note: there is a failing test at the moment ant I think the problem is in the 
test itself. See 
org.apache.wicket.ng.request.mapper.ResourceReferenceEncoderTest test methods 
testDecode2A() and testDecode3A().
org.apache.wicket.ng.resource.ResourceReferenceRegistry.Key makes a complex key 
with all available info about the resource and doesn't fallback if an optional 
info is not available. For example if we create a Key with resource name 
'resName' without locale, style, variation, ... and later try to request 
'/resName?-style' then the lookup fails instead of falling back to the 
RequestHandler registered for '/resName' like Wicket-1.4.x does.
Maybe just I don't understand it fully.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to