[
https://issues.apache.org/jira/browse/WICKET-1157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12777051#action_12777051
]
Olivier Croisier commented on WICKET-1157:
------------------------------------------
I am a bit disappointed by what you chose to integrate in the trunk...
My patch provided a pluggable strategy for the enum I18N key generation
(instead of the fixed algorithm in the classes you integrated), a generic
EnumModel that supercedes the EnumLabel, and an EnumChoiceRenderer (as an inner
class of my EnumDropdownChoice) -- both using the aforementionned key
generation strategy.
In other words, it could do more that the code you integrated, and in a more
flexible way.
I don't understand why you chose the other patch ?
(this is not a rant or personal attack, I'm just surprised and I'd like to
understand)
> Generic internationalization for Enums
> --------------------------------------
>
> Key: WICKET-1157
> URL: https://issues.apache.org/jira/browse/WICKET-1157
> Project: Wicket
> Issue Type: New Feature
> Components: wicket
> Affects Versions: 1.4-M1
> Reporter: Bruno Borges
> Assignee: Igor Vaynberg
> Fix For: 1.4.4, 1.5-M1
>
> Attachments: EnumDropDownChoice.java, EnumLabel.java, Enums.patch,
> type-choice-patch.txt, TypeChoiceModel.java, TypeChoiceRenderer.java
>
>
> Support internationalization for Enums for any Component in the future
> (Wicket's Java 5+ version). I attached two components that does this
> independently. But maybe it would be a good idea to abstract this.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
