DatesPage test LocaleDropDownChoice getObject calls getSelectedLocale(), does 
not use result
--------------------------------------------------------------------------------------------

                 Key: WICKET-3217
                 URL: https://issues.apache.org/jira/browse/WICKET-3217
             Project: Wicket
          Issue Type: Bug
          Components: wicket-datetime
    Affects Versions: 1.5-M3
         Environment: all
            Reporter: Richard Emberson
            Priority: Trivial


In the DatesPage test, the LocaleDropDownChoice.getObject() method calls
getSelectedLocale() but does not use the result:

        public List<Locale> getObject()
        {
          getSelectedLocale();
          List<Locale> locales = new ArrayList<Locale>(LOCALES);
          Collections.sort(locales, new Comparator<Locale>()
          {
            public int compare(Locale o1, Locale o2)
            {
              return o1.getDisplayName(selectedLocale).compareTo(
                  o2.getDisplayName(selectedLocale));
            }
          });
          return locales;
        }

I would guess that the call getSelectedLocale() could be removed

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to