[
https://issues.apache.org/jira/browse/WICKET-3265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12972709#action_12972709
]
Richard Emberson commented on WICKET-3265:
------------------------------------------
BTW, data_set with signature:
private final Object data_set(int index, Object object)
is used twice in Component and in neither place is the old
value returned by data_set used.
So, this method can also be simplified by not returning
the old value.
> Component data_remove returns Object which is never used
> --------------------------------------------------------
>
> Key: WICKET-3265
> URL: https://issues.apache.org/jira/browse/WICKET-3265
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.5-M3
> Environment: All
> Reporter: Richard Emberson
> Priority: Trivial
>
> The Component method data_remove has the signature:
> private Object data_remove(int position)
> It returns an Object and it is private.
> Only three places call data_remove in Component and none of them use
> the return value.
> Simplify the code in data_remove so that it does not return the data
> being removed.
> At some future time, one can always call data_get if one really needs the
> value prior to removing it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
