[ 
https://issues.apache.org/jira/browse/WICKET-3276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12973761#action_12973761
 ] 

Martin Funk commented on WICKET-3276:
-------------------------------------

Sorry that I cloned this issue, but I wasn't able to reopen.

May I have a second view on this one?

The proposed patch is not just a different way to cast. It is calling a 
different method.

If someone relies on overriding WebRequestCycle.getWebResponse(), which is 
public and not final
 like:

   private class MyRequestCycle extends WebRequestCycle {

        /* (non-Javadoc)
         * @see org.apache.wicket.protocol.http.WebRequestCycle#getWebResponse()
         */
        @Override
        public WebResponse getWebResponse() {
            WebResponse response = super.getWebResponse();
            response.setHeader("X-custom", "NewHeader" );
            return response;
        }

        public MyRequestCycle(WebApplication application, WebRequest request, 
Response response) {
            super(application, request, response);
        }

then the AjaxRequestTarget.respond(final RequestCycle requestCycle)

will not call the getWebResponse but the getResponse

and no header will be set

mf

> CLONE -How to set custom HTTP response header in Wicket's Ajax responses?
> -------------------------------------------------------------------------
>
>                 Key: WICKET-3276
>                 URL: https://issues.apache.org/jira/browse/WICKET-3276
>             Project: Wicket
>          Issue Type: Bug
>            Reporter: Martin Funk
>
> http://stackoverflow.com/questions/4397211/how-to-set-custom-http-response-header-in-wickets-ajax-responses/4399434#4399434

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to