[
https://issues.apache.org/jira/browse/WICKET-3354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12984159#action_12984159
]
Martin Grigorov commented on WICKET-3354:
-----------------------------------------
The patch looks ok.
'loggerAdapter' variable in the test seems unused.
The log assertion logic looks nice. It would be nice to introduce
BaseWicketTester.assertLogMessage(level, messageText) but this will work only
if all this can be done
with slf4j-api, otherwise we will introduce dependency to specific logging
framework ..
> Improve SerializableChecker message
> -----------------------------------
>
> Key: WICKET-3354
> URL: https://issues.apache.org/jira/browse/WICKET-3354
> Project: Wicket
> Issue Type: Improvement
> Affects Versions: 1.4.15, 1.5-M3
> Reporter: Pedro Santos
> Priority: Minor
> Attachments: WICKET-3354.patch
>
>
> Currently if the object has an problematic implementation of equals method,
> the serializable checker will stop its work with an runtime exception. The
> best would be just log an warn explaining the the problem on console and
> continue the checks until the non serializable source of the problem.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
