Author: jdonnerstag
Date: Sat Apr 23 07:36:40 2011
New Revision: 1096117
URL: http://svn.apache.org/viewvc?rev=1096117&view=rev
Log:
WICKET-3624
fixed: Remove many Eclipse warnings in wicket-request
Modified:
wicket/trunk/wicket-request/src/main/java/org/apache/wicket/request/IRequestCycle.java
wicket/trunk/wicket-request/src/main/java/org/apache/wicket/request/RequestHandlerStack.java
wicket/trunk/wicket-request/src/main/java/org/apache/wicket/request/flow/RedirectToUrlException.java
wicket/trunk/wicket-request/src/main/java/org/apache/wicket/request/http/flow/AbortWithHttpErrorCodeException.java
wicket/trunk/wicket-request/src/test/java/org/apache/wicket/request/http/handler/RedirectRequestHandlerTest.java
wicket/trunk/wicket-request/src/test/java/org/apache/wicket/request/mapper/mount/MountParametersTest.java
Modified:
wicket/trunk/wicket-request/src/main/java/org/apache/wicket/request/IRequestCycle.java
URL:
http://svn.apache.org/viewvc/wicket/trunk/wicket-request/src/main/java/org/apache/wicket/request/IRequestCycle.java?rev=1096117&r1=1096116&r2=1096117&view=diff
==============================================================================
---
wicket/trunk/wicket-request/src/main/java/org/apache/wicket/request/IRequestCycle.java
(original)
+++
wicket/trunk/wicket-request/src/main/java/org/apache/wicket/request/IRequestCycle.java
Sat Apr 23 07:36:40 2011
@@ -50,5 +50,10 @@ public interface IRequestCycle
*/
void scheduleRequestHandlerAfterCurrent(IRequestHandler handler);
+ /**
+ * Returns {@link UrlRenderer} for this {@link IRequestCycle}.
+ *
+ * @return UrlRenderer instance.
+ */
UrlRenderer getUrlRenderer();
}
Modified:
wicket/trunk/wicket-request/src/main/java/org/apache/wicket/request/RequestHandlerStack.java
URL:
http://svn.apache.org/viewvc/wicket/trunk/wicket-request/src/main/java/org/apache/wicket/request/RequestHandlerStack.java?rev=1096117&r1=1096116&r2=1096117&view=diff
==============================================================================
---
wicket/trunk/wicket-request/src/main/java/org/apache/wicket/request/RequestHandlerStack.java
(original)
+++
wicket/trunk/wicket-request/src/main/java/org/apache/wicket/request/RequestHandlerStack.java
Sat Apr 23 07:36:40 2011
@@ -42,7 +42,7 @@ public abstract class RequestHandlerStac
private IRequestHandler scheduledAfterCurrent = null;
/**
- * {@inheritDoc}
+ * @return active handler
*/
public IRequestHandler getActive()
{
@@ -50,7 +50,7 @@ public abstract class RequestHandlerStac
}
/**
- * {@inheritDoc}
+ * @param handler
*/
public void execute(final IRequestHandler handler)
{
@@ -98,14 +98,16 @@ public abstract class RequestHandlerStac
}
/**
- * Allows the request handler to response to the request
+ * Allows the request handler to respond to the request
*
* @param handler
*/
protected abstract void respond(IRequestHandler handler);
/**
- * {@inheritDoc}
+ * Schedules the handler after the current one
+ *
+ * @param handler
*/
public void schedule(final IRequestHandler handler)
{
@@ -113,7 +115,7 @@ public abstract class RequestHandlerStac
}
/**
- * {@inheritDoc}
+ * @return scheduled request handler after the current one
*/
public IRequestHandler next()
{
@@ -121,7 +123,7 @@ public abstract class RequestHandlerStac
}
/**
- * {@inheritDoc}
+ * @param handler
*/
public void replaceAll(final IRequestHandler handler)
{
@@ -136,7 +138,7 @@ public abstract class RequestHandlerStac
}
/**
- * {@inheritDoc}
+ * Detaches all request handlers
*/
public void detach()
{
Modified:
wicket/trunk/wicket-request/src/main/java/org/apache/wicket/request/flow/RedirectToUrlException.java
URL:
http://svn.apache.org/viewvc/wicket/trunk/wicket-request/src/main/java/org/apache/wicket/request/flow/RedirectToUrlException.java?rev=1096117&r1=1096116&r2=1096117&view=diff
==============================================================================
---
wicket/trunk/wicket-request/src/main/java/org/apache/wicket/request/flow/RedirectToUrlException.java
(original)
+++
wicket/trunk/wicket-request/src/main/java/org/apache/wicket/request/flow/RedirectToUrlException.java
Sat Apr 23 07:36:40 2011
@@ -34,11 +34,25 @@ public class RedirectToUrlException exte
{
private static final long serialVersionUID = 1L;
+ /**
+ * Construct.
+ *
+ * @param redirectUrl
+ * URL to redirect to.
+ */
public RedirectToUrlException(final String redirectUrl)
{
this(redirectUrl, HttpServletResponse.SC_MOVED_TEMPORARILY);
}
+ /**
+ * Construct.
+ *
+ * @param redirectUrl
+ * URL to redirect to.
+ * @param statusCode
+ * 301 (Moved permanently) or 302 (Moved temporarily)
+ */
public RedirectToUrlException(final String redirectUrl, final int
statusCode)
{
super(new RedirectRequestHandler(redirectUrl, statusCode),
true);
Modified:
wicket/trunk/wicket-request/src/main/java/org/apache/wicket/request/http/flow/AbortWithHttpErrorCodeException.java
URL:
http://svn.apache.org/viewvc/wicket/trunk/wicket-request/src/main/java/org/apache/wicket/request/http/flow/AbortWithHttpErrorCodeException.java?rev=1096117&r1=1096116&r2=1096117&view=diff
==============================================================================
---
wicket/trunk/wicket-request/src/main/java/org/apache/wicket/request/http/flow/AbortWithHttpErrorCodeException.java
(original)
+++
wicket/trunk/wicket-request/src/main/java/org/apache/wicket/request/http/flow/AbortWithHttpErrorCodeException.java
Sat Apr 23 07:36:40 2011
@@ -41,6 +41,8 @@ public final class AbortWithHttpErrorCod
* @param errorCode
* the servlet error code; use one of the
* {@link javax.servlet.http.HttpServletResponse} constants
+ * @param message
+ * the optional message to send to the client
* @see javax.servlet.http.HttpServletResponse
*/
public AbortWithHttpErrorCodeException(final int errorCode, final
String message)
Modified:
wicket/trunk/wicket-request/src/test/java/org/apache/wicket/request/http/handler/RedirectRequestHandlerTest.java
URL:
http://svn.apache.org/viewvc/wicket/trunk/wicket-request/src/test/java/org/apache/wicket/request/http/handler/RedirectRequestHandlerTest.java?rev=1096117&r1=1096116&r2=1096117&view=diff
==============================================================================
---
wicket/trunk/wicket-request/src/test/java/org/apache/wicket/request/http/handler/RedirectRequestHandlerTest.java
(original)
+++
wicket/trunk/wicket-request/src/test/java/org/apache/wicket/request/http/handler/RedirectRequestHandlerTest.java
Sat Apr 23 07:36:40 2011
@@ -23,11 +23,17 @@ import org.apache.wicket.request.http.We
import org.junit.Test;
import org.mockito.Mockito;
+/**
+ * RedirectRequestHandlerTest
+ */
public class RedirectRequestHandlerTest
{
private static final String REDIRECT_URL = "redirectUrl";
+ /**
+ * permenanentlyMovedShouldSetLocationHeader()
+ */
@Test
public void permenanentlyMovedShouldSetLocationHeader()
{
@@ -45,6 +51,9 @@ public class RedirectRequestHandlerTest
Mockito.verify(webResponse).setHeader("Location", REDIRECT_URL);
}
+ /**
+ * tempMovedShouldRedirect()
+ */
@Test
public void tempMovedShouldRedirect()
{
Modified:
wicket/trunk/wicket-request/src/test/java/org/apache/wicket/request/mapper/mount/MountParametersTest.java
URL:
http://svn.apache.org/viewvc/wicket/trunk/wicket-request/src/test/java/org/apache/wicket/request/mapper/mount/MountParametersTest.java?rev=1096117&r1=1096116&r2=1096117&view=diff
==============================================================================
---
wicket/trunk/wicket-request/src/test/java/org/apache/wicket/request/mapper/mount/MountParametersTest.java
(original)
+++
wicket/trunk/wicket-request/src/test/java/org/apache/wicket/request/mapper/mount/MountParametersTest.java
Sat Apr 23 07:36:40 2011
@@ -22,9 +22,15 @@ import static org.junit.Assert.assertTru
import org.apache.wicket.util.string.StringValue;
import org.junit.Test;
+/**
+ * MountParametersTest
+ */
public class MountParametersTest
{
+ /**
+ * getNonExistingPlaceholder()
+ */
@Test
public void getNonExistingPlaceholder()
{
@@ -34,6 +40,9 @@ public class MountParametersTest
assertTrue(value.isNull());
}
+ /**
+ * getExistingPlaceholder()
+ */
@Test
public void getExistingPlaceholder()
{
@@ -47,6 +56,9 @@ public class MountParametersTest
assertEquals(originalValue.toString(), actualValue.toString());
}
+ /**
+ * cannotModifyByNamesSet()
+ */
@Test(expected = UnsupportedOperationException.class)
public void cannotModifyByNamesSet()
{
