[ https://issues.apache.org/jira/browse/WICKET-3741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13039691#comment-13039691 ]
Martin Grigorov edited comment on WICKET-3741 at 5/26/11 1:02 PM: ------------------------------------------------------------------ A patch that solves the problem. There is only one test that fails when executed in suite. When executed alone it passes - org.apache.wicket.markup.html.form.FormComponentPanelProcessingTest#testProcessingOrder(). This test fails with: testProcessingOrder(org.apache.wicket.markup.html.form.FormComponentPanelProcessingTest) Time elapsed: 0.009 sec <<< ERROR! org.apache.wicket.markup.MarkupException: Close tag not found for tag: <wicket:panel>. Component: [TestFormComponentPanel [Component id = panel]] [markup = org.apache.wicket.util.resource.StringResourceStream@37b3e1c9: <wicket:panel><input wicket:id='text' type='text'/></wicket:panel> <wicket:panel><input wicket:id="text" type="text"/></wicket:panel>, index = 1, current = '<input wicket:id="text" type="text"/>' (line 0, column 0)] was (Author: mgrigorov): A patch that solves the problem. There is only one test that fails when executed in suite. When executed alone it passes - org.apache.wicket.markup.html.form.FormComponentPanelProcessingTest#testProcessingOrder() > Introduce lightweight WicketRuntimeException for the cases when it can be > ignored > --------------------------------------------------------------------------------- > > Key: WICKET-3741 > URL: https://issues.apache.org/jira/browse/WICKET-3741 > Project: Wicket > Issue Type: Improvement > Components: wicket-core > Affects Versions: 1.5-RC4 > Reporter: Martin Grigorov > Assignee: Martin Grigorov > Attachments: WICKET-3741.patch > > > Some areas in Wicket code do expensive creation of WicketRuntimeException and > then just ignores it. > The most common case is : > at java.lang.Throwable.fillInStackTrace(Native Method) > at java.lang.Throwable.<init>(Throwable.java:218) > at java.lang.Exception.<init>(Exception.java:59) > at java.lang.RuntimeException.<init>(RuntimeException.java:61) > at > org.apache.wicket.WicketRuntimeException.<init>(WicketRuntimeException.java:49) > at org.apache.wicket.MarkupContainer.getMarkupType(MarkupContainer.java:476) > at > org.apache.wicket.markup.DefaultMarkupCacheKeyProvider.getCacheKey(DefaultMarkupCacheKeyProvider.java:85) > at org.apache.wicket.markup.MarkupCache.getMarkup(MarkupCache.java:274) > at org.apache.wicket.markup.MarkupFactory.getMarkup(MarkupFactory.java:218) > at org.apache.wicket.markup.MarkupFactory.getMarkup(MarkupFactory.java:192) > at > org.apache.wicket.MarkupContainer.getAssociatedMarkup(MarkupContainer.java:410) > at > org.apache.wicket.markup.html.panel.PanelMarkupSourcingStrategy.getMarkup(PanelMarkupSourcingStrategy.java:70) > at org.apache.wicket.MarkupContainer.getMarkup(MarkupContainer.java:456) > at org.apache.wicket.Component.getMarkup(Component.java:734) > at org.apache.wicket.MarkupContainer.add(MarkupContainer.java:173) > ... > and is ignored in MarkupContainer#add(). > Such an exception is created for every component which is added in the > constructor of another component (in contrast to onInitialize() where the > markup will be available). -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira