[ 
https://issues.apache.org/jira/browse/WICKET-3778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13045979#comment-13045979
 ] 

Pedro Santos commented on WICKET-3778:
--------------------------------------

The patch looks OK. The API is cohesive, it does not involve java.io interfaces 
as IPageSerializer did in 1.4.
I think you forget the kryo dependence in the wicket-core pom since you said it 
will be in wicket-stuff and there are no kyro API usage in the patch.

Also I think we can remove IObjectStreamFactory and WicketObjectIn/OutputStream 
since we are providing a pluggable place to user set how serialization will to 
be done. As a side effect we can close WICKET-3192.

> Add possibility to register different page serializer
> -----------------------------------------------------
>
>                 Key: WICKET-3778
>                 URL: https://issues.apache.org/jira/browse/WICKET-3778
>             Project: Wicket
>          Issue Type: New Feature
>          Components: wicket-core
>    Affects Versions: 1.5-RC4
>            Reporter: Martin Grigorov
>         Attachments: wicket-3778.patch
>
>
> Currently Wicket uses default Java serialization to persist/load the page 
> to/from the backing stores.
> There are serialization libraries which claim to be more performant than Java 
> serialization.
> With this ticket I want to make Wicket more configurable by introducing 
> IPageSerializer interface with Java serialization as default implementation 
> (as it works today).
> Additionally I'll add an implementation based on 
> http://code.google.com/p/kryo/ in wicketstuff project at Github.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to