[
https://issues.apache.org/jira/browse/WICKET-4707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13433809#comment-13433809
]
Jesse Long commented on WICKET-4707:
------------------------------------
I have had a look at this, and implemented changes to use HeaderItems widely
instead of ResourceReferences. It saves a lot of
JavaScriptHeaderItem.forReference() calls, but ultimately leads to more
complicated code than is currently necessary in Wicket - especially with regard
to resource bundles. For this reason, and because of the API changes for very
little benefit I've giving up on the patch. Changes at
https://github.com/jesselong/wicket/commits/WICKET-4707 if anyone cares. Sorry
for the noise.
> Remove ResourceReference.getDependencies()
> ------------------------------------------
>
> Key: WICKET-4707
> URL: https://issues.apache.org/jira/browse/WICKET-4707
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 6.0.0-beta3
> Reporter: Jesse Long
> Priority: Minor
>
> There is some duplication of functionality between the ResourceReference and
> HeaderItem layers.
> ResourceReferences should not be responsible for managing header contribution
> dependencies. This is the job of HeaderItem. ResourceReference's job is to
> provide a reference to a IResource. In that context, getDependencies()
> unnecessary.
> ResourceReference is the layer below HeaderItem, but implementation problems
> of HeaderItem have crept into the lower layer.
> In the same vein, IJavaScriptLibrarySettings should manage HeaderItems, not
> ResourceReferences. It is concerned with making sure that the correct header
> contributions have been made for the various Javascript things to work. This
> can be done entirely without ResourceReferences, but not without HeaderItems.
> The important things is the header items.
> Working on some patches...
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
